[#661] Refactors support for proxy configuration for greater flexibility #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@ProNotion we need also to change sample code and readme file to reflect that change |
|
and i think we can also have both option so need need to stop the old code for developer after they upgrade |
…tibility Updates the README with an example
|
@abuzuhri PR updated with the requested changes |
|
@abuzuhri Is there anything else you want to change about this, or is it all good now? |
|
@ProNotion could you resolve the conflicts on the PR please? |
# Fixed conflicts: # README.md # Source/FikaAmazonAPI/AmazonCredential.cs
|
@dansharpe83 Conflicts resolved |
|
@abuzuhri Can I ask why this will not be merged, please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Passing an instance of
IWebProxyallows for greater flexibility without restricting consumers to just providing a host, for instance, credentials may also be required.